Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown parsing issue #48

Open
rahul286 opened this issue Nov 29, 2018 · 3 comments
Open

Markdown parsing issue #48

rahul286 opened this issue Nov 29, 2018 · 3 comments

Comments

@rahul286
Copy link
Member

rahul286 commented Nov 29, 2018

Please check screenshot here https://twitter.com/brianjking/status/1067864888041566208

It appears that markdown parser is not working completely or isn't compatible with Gutenberg editor.

We likely need to fix this on WordPress end.

@rahul286
Copy link
Member Author

@rahulsprajapati we might need to fix https://github.com/mAAdhaTTah/wordpress-github-sync if it doesn't support Gutenberg.

I am not sure how Gutenberg's HTML comment will work with Markdown.

So for time being, we might need to disable Gutenberg on handbook CPT. We can use https://wordpress.org/plugins/gutenberg-ramp/ for this part (if needed).

@brianjking
Copy link

@rahul286 Are you indicating that the docs should in fact be standard markdown that is then parsed and generated into WordPress posts/pages with appropriate formatting? If so, this is great news.

@rahul286
Copy link
Member Author

rahul286 commented Dec 1, 2018

@brianjking Yep. The intention is to not only use plain & simple markdown but also use Jekyll and front-matter https://jekyllrb.com/docs/front-matter/

Now the WordPress is used as a presentation layer. This way we don't need to design or maintain a separate Jekyll theme.

Besides, we can use some WordPress features such as SEO plugins, related posts/docs, and more.

With WordPress, we will be able to allow logged in users to subscribe to pages they are interested in and receive changes to those pages via email!

Now, we started with a good plugin https://github.com/mAAdhaTTah/wordpress-github-sync which takes care of data sync part between markdown files here and WordPress post content nicely. It's just the plugin we depend on isn't tested with Gutenberg.

Our devs couldn't fix yet as we are clueless as of how to preserve Gutenberg comments on markdown sync. But if that turns out to be a blocker, we will remove Gutenberg for the documentation part.

Documentation being simple pages, may not require Gutenberg.

@rahulsprajapati rahulsprajapati removed their assignment Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants