Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better @Abstract output for classmethods and staticmethods #67

Open
prusse-martin opened this issue Jan 25, 2022 · 0 comments
Open

Better @Abstract output for classmethods and staticmethods #67

prusse-martin opened this issue Jan 25, 2022 · 0 comments

Comments

@prusse-martin
Copy link
Member

Abstract is designed to be used with instance methods.

class Foo:
    @Abstract
    def DoStuff(self):
        """Implementation to do stuff."""

Uses with classmethods are possible and work as expected

class Foo:
    @classmethod
    @Abstract
    def DoStuff(cls):
        """Implementation to do stuff."""

But when an implementation is missing in the sub class no reference to the offending class is present (just type).
In this issue we should add proper support for class methods (better error message) and better describe this in the docstring (also that staticmethods are not supported).

@nicoddemus nicoddemus changed the title Better output for @Abstract Better @Abstract output for classmethods and staticmethods Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant