Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RTT behavior with respect to summary lengths #40

Open
arhag opened this issue Jun 3, 2019 · 0 comments
Open

Change RTT behavior with respect to summary lengths #40

arhag opened this issue Jun 3, 2019 · 0 comments

Comments

@arhag
Copy link
Contributor

arhag commented Jun 3, 2019

RTT will avoid processing a Ricardian contract if the length of the raw summary is greater than 116 characters.

Furthermore, if the generated summary is greater than 116 characters, RTT will simply truncate the generated summary string to fit. I consider this truncation to be a bug: if the spec required the generated string to be no more than 116 character (which I'm not sure if it does because it is ambiguously worded) then it should not return any successful result. But I think it would be better for the library to just return the full generated string, however long it is, and allow the authenticate UI to enforce any truncation it wants.

Better yet, if this (EOSIO/ricardian-spec#20) proposed change to the Ricardian spec is adopted, then RTT should not enforce any limit on the summary. Such a limit could optionally be enforced in the authenticator UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant