Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gpu yuv conversion on godot-stable #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EgrorBs
Copy link

@EgrorBs EgrorBs commented Jul 23, 2024

With this fix GPU YUV conversion needs rendering device and Godot 4.3+

Fixes #23

Tested on Godot-stable (4.2.2.stable.official.15073afe3) and Godot-latest (4.3.dev6.official.89850d553) on compat and forward+ renderers

@EIREXE
Copy link
Contributor

EIREXE commented Aug 30, 2024

I am very sorry for the delay, I was on vacation.

Do we need this anymore now that 4.3 has released?

@EgrorBs
Copy link
Author

EgrorBs commented Sep 2, 2024

I hope you had a great vacation! :)

Personally, I think including this would improve compatibility, which is always a good thing, but it's totally up to you.

@juntaosun
Copy link

@EgrorBs I tested WebM transparent video, which contains BGRA channels, but after decoding with EIRTeam.FFmpeg, the pixels obtained only have BGR channels. The transparent pixels are lost.

`
yuv420p

yuva420p (transparent)
`
#38 (comment)

@juntaosun
Copy link

juntaosun commented Oct 28, 2024

@EgrorBs Version v1.1.1 has been released and supports yuva. But it requires ffmpeg to be compiled with --enable-libvpx enabled. Can it be updated to compile an Android extension?

https://trac.ffmpeg.org/wiki/Encode/VP9

--enable-libvpx:  
To install FFmpeg with support for libvpx-vp9, look at the [Compilation Guides] 
 (https://ffmpeg.org/trac/ffmpeg/wiki/CompilationGuide) and compile FFmpeg with the option. Note that for 10-bit encoding,  
 you need to set the configuration option. --enable-libvpx--enable-vp9-highbitdepth  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V1.1.0 video does not work on windows with latest stable godot (4.2.2)
3 participants