Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with multiple advancements in the same enemy turn #521

Open
Toranks opened this issue Jun 27, 2023 · 3 comments
Open

Bug with multiple advancements in the same enemy turn #521

Toranks opened this issue Jun 27, 2023 · 3 comments

Comments

@Toranks
Copy link
Collaborator

Toranks commented Jun 27, 2023

If a unit with special advances advances twice in the enemy's turn, when your turn comes, you can select two advances consecutively, but the first isn't applied, only the last.

To test:

  • Load this save: Multiple advancements.gz
  • End turn
  • Philips will kill all lizards and advance twice during the enemy turn
  • When the player's turn arrives, he receives two progress dialogs in a row
  • Choose at ease
  • Observe how only the last one takes effect, both in unit itself and in unit info (shift+c)
@Discontinuum
Copy link
Contributor

This is a very old thing, I remember discussing it several years ago with Dugi and at the time neither of us tried to fix it because code around advancements is quite complicated and the chances of getting multiple advancements during one turn are not too high

@Toranks
Copy link
Collaborator Author

Toranks commented Jun 27, 2023

In the end, what I did was move Philips away enough so that he didn't kill as many lizards in one turn. It is a special unit with very low EXP to go up quickly, it is true that it is something that happens rarely.

@Discontinuum
Copy link
Contributor

It's curious that if one looks into "force respec" code, it seems it tries to deal with this situation, it counts the number of "backup_amlas", and after all it calls the advancement procedure the correct number of times. But for some reason it loses all the intermediate results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants