Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[harm_unit_loti] doesn't recognize first and second unit #487

Open
Toranks opened this issue Jun 7, 2023 · 2 comments
Open

[harm_unit_loti] doesn't recognize first and second unit #487

Toranks opened this issue Jun 7, 2023 · 2 comments

Comments

@Toranks
Copy link
Collaborator

Toranks commented Jun 7, 2023

To check, load this game and attack the pirate with Akula. The savegame is modified to have a 100% chance to disintegrate.
You will see that the pirate talks to herself as if she were the attacker and the victim at the same time.

LotI1-Piratas Turno 18 harm_unit_loti.gz

Now load this other savegame, here in addition to 100% chance, harm_unit_loti was changed to the original harm_unit on the disintegrate event. Everything else is equal. As you can see, the pirate now talks correctly with Akula.

LotI1-Piratas Turno 18 harm_unit.gz

@Discontinuum
Copy link
Contributor

I didn't check the replays, I think this may be the case (vaguely remember something) but can't say for sure. But it's very strange if it's the case, the comment in lua said the lua implementation of harm_unit_loti was supposed to be a copypaste of harm_unit with some tweaks for experience in aoe attacks. In theory it should work the same.

@Dugy
Copy link
Owner

Dugy commented Jun 9, 2023

Yes, but a lot of things have changed in the original since the copypaste was made, and it's possible something in the lua engine has changed and the lua code of harm_unit was updated, while harm_unit_loti wasn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants