Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

루비 온 레일즈 버전 4.1.7로 업그레이드하기 #381

Open
shaynekang opened this issue Oct 31, 2014 · 5 comments
Open

루비 온 레일즈 버전 4.1.7로 업그레이드하기 #381

shaynekang opened this issue Oct 31, 2014 · 5 comments
Assignees
Labels

Comments

@shaynekang
Copy link

루비 온 레일즈 4.1.7이 릴리즈 되었습니다
ActionPack에 관한 보안 이슈가 발견되었는데 이를 반영한 패치입니다. 조속히 업그레이드 해야 할 것 같네요. ㅎㅎ

@shaynekang
Copy link
Author

이런 보안 이슈는 테스팅을 거치지 않고 바로 Production에 올려주시면 될 것 같습니다. ㅎㅎ

@yhoonkim yhoonkim self-assigned this Nov 8, 2014
@yhoonkim
Copy link
Contributor

yhoonkim commented Nov 9, 2014

테스팅해보니 routing이 막 변해서 당분간 보류하는걸로 하겠습니다.

@shaynekang
Copy link
Author

👍

@angdev
Copy link
Member

angdev commented Nov 10, 2014

child 레벨이 1이 넘어가면 shallow가 제대로 작동하지 않는 문제를 rails/rails#15783 에서 해결해서 생긴 문제입니다.

아래와 같이 routes.rb를 고치면 작동하도록 할 수는 있지만 나중에 고치는 걸로 합시다 ㅠㅠ

diff --git a/config/routes.rb b/config/routes.rb
index 679d811..5e1a5dc 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -22,8 +22,11 @@ Rails.application.routes.draw do
       resources :responses
       resources :to_responses
       resources :checklists, shallow: true do
+        resources :assignee_comments, except: [:index, :create, :new]
+      end
+      resources :checklists, only: [] do
+        resources :assignee_comments, only: [:index, :create, :new]
         get 'finish'
-        resources :assignee_comments
       end
     end

@@ -58,7 +61,7 @@ Rails.application.routes.draw do
           get 'download_roster_example'
         end

-        member do 
+        member do
           get 'to_notice_end_deadline'
           patch 'to_notice_change_deadline'
         end
@@ -72,9 +75,11 @@ Rails.application.routes.draw do
         end
       end

-      resources :bank_accounts, shallow: true do
-        resources :expense_records
+      resources :bank_accounts, except: [:index, :create, :new] do
+        resources :expense_records, shallow: true
       end
+      resources :bank_accounts, only: [:index, :create, :new], shallow: true
+

       resource :export_excel,  controller: :export_excel,  only: [:new, :create]
       resources :messages

@yhoonkim
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants