VAT tax type upside-down

[Iledher]

Bug

New field in VAT dictionnary "VAT accounts" -> Tax type ("all", "buy", "sell") seem to work upside-down. "Buy" codes are only usable in sells actions, and "sell" codes in buy actions.

Dolibarr Version

20.0.3

Environment PHP

No response

Environment Database

No response

Steps to reproduce the behavior and expected behavior

Create a new "VAT accounts" in the VAT dictionnary, with Tax type "Sell" :

This new VAT code is now only display in Vendor Invoices lines and purchase orders lines.

On the contrary, if the tax type is "Buy", the VAT code is only display in Sales Order and Customer Invoices.

Attached files

No response

[Daviid-P]

Seems that way.

dolibarr/htdocs/core/class/html.form.class.php

Line 7019 in 77c8457

if (empty($cachevalue['type_vat']) || $cachevalue['type_vat'] != $type_vat) {

If we're trying to keep only the VAT qualified for $type_vat it probably should be $cachevalue['type_vat'] == $type_vat