Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement step 3. D of the line length determination algorithm #121

Closed
TimJentzsch opened this issue Jun 9, 2022 · 1 comment
Closed

Implement step 3. D of the line length determination algorithm #121

TimJentzsch opened this issue Jun 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@TimJentzsch
Copy link
Collaborator

What problem does this solve or what need does it fill?

Step 3. D of the line length determination algorithm is missing in the implementation.

https://github.com/DioxusLabs/sprawl/blob/11701ee97d68b22a231cac081aab4308af136706/src/flexbox.rs#L354-L360

What solution would you like?

The step should be implemented according to the specification

What alternative(s) have you considered?

We could decide to divert from the spec in this case.

Additional context

Originally discussed in #39.
@TimJentzsch TimJentzsch added the enhancement New feature or request label Jun 9, 2022
@alice-i-cecile alice-i-cecile added the good first issue Good for newcomers label Jun 12, 2022
@nicoburns nicoburns added bug Something isn't working and removed enhancement New feature or request good first issue Good for newcomers labels Dec 30, 2022
@nicoburns
Copy link
Collaborator

This is only relevant if vertical writing modes are supported. So closing in favour of #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicoburns @alice-i-cecile @TimJentzsch