Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handling of device factories #844

Open
DiamondJoseph opened this issue Oct 16, 2024 · 0 comments
Open

Simplify handling of device factories #844

DiamondJoseph opened this issue Oct 16, 2024 · 0 comments

Comments

@DiamondJoseph
Copy link
Contributor

After the state of device factories is settled, the code that calls those factories could do with being neatened.
Currently, there are undocumented kwargs that are passed through to the device_instantiation method.
Once all devices are ophyd-async and can use the device_factory decorator, make_all_devices can have the same method signature as the connect method on the DeviceInitializationController callable.

Acceptance Criteria

  • There is one way of denoting/configuring a device factory
  • There is one way to get all of the device factories in a beamline
  • There is one way to get the devices created by all of the device factories on a beamline
  • The standard is documented as part of the dodal documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant