Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will a typo fix PR be considered for merge? #102

Open
luzpaz opened this issue Dec 19, 2024 · 3 comments
Open

Will a typo fix PR be considered for merge? #102

luzpaz opened this issue Dec 19, 2024 · 3 comments

Comments

@luzpaz
Copy link

luzpaz commented Dec 19, 2024

@Dhondtguido
I have a pending PR that I haven't sent yet but it needs a rebase. It is a typo fixing PR. I'd like to know if it will be considered for merge? If there is a possibility at all, I'll submit it. (I ask because some devs don't want to accept typo fix PRs).

Thanks for your consideration.

@FEA-eng
Copy link

FEA-eng commented Dec 22, 2024

My PR with documentation typo fixes was closed: #92

@luzpaz
Copy link
Author

luzpaz commented Jan 11, 2025

looks like it was re-opened.

@luzpaz
Copy link
Author

luzpaz commented Jan 11, 2025

Here is the patch for pre-review. I'd be happy to submit it.
master...luzpaz:CalculiX:typos

Note: if history pollution is a concern, the practice of having a .git-blame-ignore-revs file can be used. See https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants