Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address performance of tab loading during first chord playback #17

Open
Devin-Mix opened this issue Mar 29, 2023 · 0 comments
Open

Address performance of tab loading during first chord playback #17

Devin-Mix opened this issue Mar 29, 2023 · 0 comments
Assignees
Labels
bug Something isn't working P2 Moderate-priority issue or feature that should be addressed in a timely manner but lacks urgency

Comments

@Devin-Mix
Copy link
Owner

Currently, generation of the playback audio track, tone wave track, and input device recording session created during the recording state all occur when the first chord shown in the GUI is intended to be struck. In practice, this creates a significant lag spike which causes the GUI and audio tracks to become desynchronized. To address this, those same audio-related tasks should be handled when the GUI Event Broker or Recording State Manager (whichever is more appropriate) are prompted to start a new recording session. This will shift the delay to the start of the playback session which, while still not ideal in cases where the user's chord falling time is set to a low value, will be significantly less noticeable or disruptive.

@Devin-Mix Devin-Mix self-assigned this Mar 29, 2023
@Devin-Mix Devin-Mix added bug Something isn't working P2 Moderate-priority issue or feature that should be addressed in a timely manner but lacks urgency labels Mar 29, 2023
@Devin-Mix Devin-Mix added this to the Presentation 3 milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 Moderate-priority issue or feature that should be addressed in a timely manner but lacks urgency
Projects
None yet
Development

No branches or pull requests

1 participant