Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different vertical hydraulic conductivity profiles #254

Open
verseve opened this issue Mar 14, 2024 · 2 comments
Open

Support different vertical hydraulic conductivity profiles #254

verseve opened this issue Mar 14, 2024 · 2 comments
Labels
enhancement New feature or request needs refinement issue still needs refinement workflows Issue linked to the workflows

Comments

@verseve
Copy link
Member

verseve commented Mar 14, 2024

Kind of request

Adding new functionality

Enhancement Description

Different vertical hydraulic conductivity for the SBM concept are now supported in Wflow.jl. It would be useful to add this option also to hydromt_wflow. The different options are described in The-SBM-soil-water-accounting-scheme and Subsurface flow routing.

Use case

See Deltares/Wflow.jl#313.

Additional Context

No response

@verseve verseve added enhancement New feature or request needs refinement issue still needs refinement labels Mar 14, 2024
@hboisgon hboisgon added the workflows Issue linked to the workflows label Mar 19, 2024
@hboisgon hboisgon added this to the 2024 - high priority milestone Mar 19, 2024
@hboisgon
Copy link
Contributor

I think now that we have the method to resample the c parameter for different wflow layers, this should be relatively straightforward to do and apply to ksatver as well. I guess this would have an influence on the paddy / irrigation workflow in #226 as we would have to update also ksatver and not just c right?
Then maybe we need a bit of restructure to separate the parameters defined for the wflow soil depths and the others.

@verseve
Copy link
Member Author

verseve commented Aug 29, 2024

I think now that we have the method to resample the c parameter for different wflow layers, this should be relatively straightforward to do

Yes, I agree, the implementation of this functionality is relatively straightforward. I think it would be good to also include an additional method to estimate the soil depth (now from SoilGrids with a max depth of 2 m). These ksat profiles have also been added to wflow for soil depths for which soil measurements are not available. For example this method from wflow_sbm.py: https://github.com/openstreams/wflow/blob/master/wflow/wflow_sbm.py#L1923.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs refinement issue still needs refinement workflows Issue linked to the workflows
Projects
None yet
Development

No branches or pull requests

2 participants