Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with nodata requirements of core #208

Closed
Jaapel opened this issue Oct 19, 2023 · 0 comments · Fixed by #229
Closed

Compatibility with nodata requirements of core #208

Jaapel opened this issue Oct 19, 2023 · 0 comments · Fixed by #229
Assignees
Labels
enhancement New feature or request

Comments

@Jaapel
Copy link

Jaapel commented Oct 19, 2023

Kind of request

Changing existing functionality

Enhancement Description

The current version of hydromt_wflow does not work with core 0.9 because of how missing data is handled in the DataAdapters. I propose a new method here: Deltares/hydromt#584. Implementing this with the current behaviour of the wflow plugin (ignore) could be as simple as adding a flag to ignore missing data (like reservoirs) or to raise if the component is critical for the model (like rainfall).

Use case

If I want to run with the main branch of HydroMT (in this case for the cloud pilot), this feature should be implemented.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants