Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: better document data for default wflow setup #157

Open
6 tasks
DirkEilander opened this issue Mar 8, 2023 · 2 comments
Open
6 tasks

ENH: better document data for default wflow setup #157

DirkEilander opened this issue Mar 8, 2023 · 2 comments
Labels
datasets supporting new datasets documentation Improvements or additions to documentation

Comments

@DirkEilander
Copy link
Contributor

DirkEilander commented Mar 8, 2023

Some datasets like LAI have undergone some preprocessing to derive monthly climatology, see #156
Other datasets like MERIT_Hydro have a few derivative layers (basins, stream order, etc) that are not well described, this relates to #89 .
It would be good to better document or even script the steps taken before this data can be used in hydromt-wflow.

Known issues:

  • MODIS LAI
  • MERIT Hydro basins index
  • MERIT Hydro additionnal layers (stream order, basins)
  • MERIT Hydro vrt format (combining tiles yourself is often prone to error)
  • era5 orography layer
  • reservoirs / lakes database are processed from GRanD and Hydrolakes
@DirkEilander
Copy link
Contributor Author

A first step could be to add a table in the user guide with the default data sources and which setup methods these are used for. We can additionally share some data that is not currently available for direct download (e.g. MODIS LAI) via Zenodo. For MERIT Hydro we should link the 30 arcsec IHU version which includes a basin index file.

@JoostBuitink @hboisgon Let me know what you think?

Related issues #178

@DirkEilander DirkEilander changed the title ENH: share pre-processing scripts for datasets that go into the default wflow setup ENH: better document data for default wflow setup May 15, 2023
@hboisgon hboisgon added documentation Improvements or additions to documentation datasets supporting new datasets labels May 23, 2023
@hboisgon
Copy link
Contributor

@DirkEilander indeed good to document better where the default input data for wflow is coming from. The table you mention is a good idea but I think some things are also good to mention directly in hydromt core repository (eg update link for basin index or era5 orography source). Also if more users than wflow use these datasets then they'll have the same questions.

So good to also find a way to document this better in core (at least fixing the broken link), or maybe just allow for hydromt to do some of the processing steps ?
For example, lakes is mainly about filtering column based on attribute see hydromt:#97 and maybe we could create the monthly average LAI maps in setup_laimaps method and then reference the original dataset as well in the data catalog ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets supporting new datasets documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants