Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch order assigned by setup river needs improvement at bifurcation #46

Closed
xldeltares opened this issue Aug 8, 2023 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@xldeltares
Copy link
Collaborator

xldeltares commented Aug 8, 2023

Kind of request

Changing existing functionality

Enhancement Description

For now, when we use setup_river function, a branch order = 1 is by default applied, so that river crossection are interpolated. this works well in simple river cases but when river network becomes more complex, this is not correct and will give an error in the model at bifurcation locations. we should assign branch order in a more smart way.

Use case

No response

Additional Context

After discussion we decided to use branch order -1. Only when an user specifies the order, it will overwrite the -1. You need knowledge about the system to do this properly.

@xldeltares xldeltares added the enhancement New feature or request label Aug 8, 2023
@xldeltares
Copy link
Collaborator Author

closed with #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant