You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in the data_adapter, renaming of variables happens before unit conversion or type checks.
It would be more consistent to first do:
astype
unit_add
unit_mult
renmaing last
This has consequences on the data catalog format.
The dictionnary would then always have the variables names as in the original data as keys (instead of already the renamed variable for unit_mult and unit_add).
This impacts the deltares_data.yml file stored in data-artifacts but not the data extract for Piave itself.
The text was updated successfully, but these errors were encountered:
The current sequence (first renaming) is because the .raster and .vector extensions for Datasets/Arrays require correct x, y, time and index dimension names. Some minimal renaming of dimensions should therefore be the first step after reading. Note that nodata values can also be set per variable. My suggested order of the pre-processing would therefore be:
Currently in the data_adapter, renaming of variables happens before unit conversion or type checks.
It would be more consistent to first do:
This has consequences on the data catalog format.
The dictionnary would then always have the variables names as in the original data as keys (instead of already the renamed variable for unit_mult and unit_add).
This impacts the deltares_data.yml file stored in data-artifacts but not the data extract for Piave itself.
The text was updated successfully, but these errors were encountered: