Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No link to the EVA notebook in the docs #464

Closed
1 task done
hboisgon opened this issue Jul 31, 2023 · 3 comments · Fixed by #446
Closed
1 task done

No link to the EVA notebook in the docs #464

hboisgon opened this issue Jul 31, 2023 · 3 comments · Fixed by #446
Labels
Documentation Improvements or additions to documentation
Milestone

Comments

@hboisgon
Copy link
Contributor

HydroMT version checks

  • I have checked that the issue still exists on the latest versions of the docs on main here

Kind of issue

Docs are wrong

Location of the documentation

The EVA notebook was created with PR 85 but not added to the online docs.

Links should be added to make it findable in the docs in the pages:

Additionally maybe also mention something here: https://deltares.github.io/hydromt/latest/user_guide/methods_stats.html
(only the skills stats are mentioned)

Documentation problem

See above

Suggested fix for documentation

Include links

@hboisgon hboisgon added Documentation Improvements or additions to documentation Needs refinement issue still needs refinement and removed Needs refinement issue still needs refinement labels Jul 31, 2023
@hboisgon hboisgon added this to the Q3 milestone Jul 31, 2023
@savente93
Copy link
Contributor

savente93 commented Jul 31, 2023

since this is such a small thing, it might be easy to just include it in #446 ? I'm updating that one to be in sync with main now anyway, so I can add it there if you want

@savente93 savente93 linked a pull request Jul 31, 2023 that will close this issue
5 tasks
@hboisgon
Copy link
Contributor Author

hboisgon commented Aug 1, 2023

What you want but I still would like to add some texts / good practices for plugin developments in relation to HydroMT so not sure this one will be merged very soon. But you are right this is a very small thing so maybe like last time can be combined with other docs issues or another PR, I dont mind

@savente93
Copy link
Contributor

I would say it depends on when you think you can work on the Plugin docs. If you plan on working on it in the next week or so, then we can leave it, other wise it might be better to put it in a separate PR anyway. I think it's becoming not to leave things like this for too long. Up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants