Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use bump2version for versioning #173

Closed
DirkEilander opened this issue Aug 4, 2022 · 5 comments
Closed

use bump2version for versioning #173

DirkEilander opened this issue Aug 4, 2022 · 5 comments
Labels
Enhancement New feature or request

Comments

@DirkEilander
Copy link
Contributor

with bump2version and git actions we can automate versioning without it extra runtime.

example:
https://williamhayes.medium.com/versioning-using-bumpversion-4d13c914e9b8
@DirkEilander
Copy link
Contributor Author

edit the release guide

@DirkEilander DirkEilander added the Enhancement New feature or request label Oct 6, 2022
@savente93 savente93 added the Needs refinement issue still needs refinement label Jun 16, 2023
@savente93
Copy link
Contributor

bump2version hasn't seen a release since 2020 and the highest supported version that is listed is 3.8, so that one specifically is probably not a very good idea, but if there is a need for this, I'm very happy to look into alternatives

@DirkEilander
Copy link
Contributor Author

Good point. We want something that is maintained. My idea behind this issue is to have unique version numbers for each state of the main branch, also in between releases. In practice quite a few users use the latest developments, making it hard to reproduce results. This could potentially also be fixed in github workflows? Alternatively, we could release more frequently.

@savente93
Copy link
Contributor

We actually do, it's the commit hash! However I do think there is indeed much we could do we aliviate this problem, it's something I'd be happy to work on down the line. It's deifnitely something that could be fixed or at least improved with GHA. Let's brainstorm a bit on things we could do to improve this

@savente93 savente93 mentioned this issue Jul 25, 2023
Closed
5 tasks
@hboisgon hboisgon added this to the Q3 milestone Jul 26, 2023
@savente93 savente93 removed this from the Q3 milestone Aug 8, 2023
@DirkEilander
Copy link
Contributor Author

We have tried several options in #455 and decided to not go ahead with this for now. I will therefore close this issue.

@savente93 savente93 removed the Needs refinement issue still needs refinement label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dev version with GHA Deltares/hydromt
3 participants
@DirkEilander @savente93 @hboisgon