Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable dark / light modes #1046

Open
Huite opened this issue Sep 13, 2024 · 0 comments
Open

Re-enable dark / light modes #1046

Huite opened this issue Sep 13, 2024 · 0 comments
Labels
Documentation Improvements or additions to documentation Needs refinement issue still needs refinement

Comments

@Huite
Copy link
Contributor

Huite commented Sep 13, 2024

Just a general heads-up: sphinx-pydata has much improved dark mode rendering. I've just re-enabled it for pandamesh and xugrid: https://deltares.github.io/pandamesh/

The GitHub and Deltares icons are ugly in dark mode, but a little CSS will turn them white:

/* enlarge deltares & github icon size; only works with local/url svg files; not with fa icons */
img.icon-link-image {
    height: 2.5em !important;
}

[data-theme="dark"] img.icon-link-image[src*="deltares-blue.svg"] {
    filter: brightness(0) saturate(100%) invert(100%);
}
[data-theme="dark"] img.icon-link-image[src*="Octicons-mark-github.svg"] {
    filter: brightness(0) saturate(100%) invert(100%);
}

This might not solve all the issues brought up in #136, but it might be worthwhile to experiment locally. Seems like the logo is an SVG now; the getting started image has been altered.

You might be able to remove this line:

"navbar_end": ["navbar-icon-links", "version-switcher"], # remove dark mode switch

Then add a little CSS and enjoy your dark mode.

For pandamesh, I already had a small white border around the blue circle; for xugrid I added it with inkscape, just click the circle and set the stroke paint to white. You might also be able to edit it directly in the SVG:

    <circle
       style="fill:#080c80;fill-opacity:1;stroke-width:0.264583"

To something like:

    <circle
       style="fill:#080c80;fill-opacity:1;stroke:#ffffff;stroke-width:0.3;stroke-dasharray:none;stroke-opacity:1"
@Huite Huite added Documentation Improvements or additions to documentation Needs refinement issue still needs refinement labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Needs refinement issue still needs refinement
Projects
None yet
Development

No branches or pull requests

1 participant