Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pytest tmp_dir instead of manually creating and deleting output folders #734

Closed
Tracked by #694
veenstrajelmer opened this issue Jan 23, 2024 · 0 comments · Fixed by #735
Closed
Tracked by #694

use pytest tmp_dir instead of manually creating and deleting output folders #734

veenstrajelmer opened this issue Jan 23, 2024 · 0 comments · Fixed by #735

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jan 23, 2024 •
edited
Loading

delete directory from download tests: https://docs.pytest.org/en/6.2.x/tmpdir.html

Also apply for tests that create temp_fnc_default_fillvals_map.nc and temp_fillvals_map.nc
@veenstrajelmer veenstrajelmer mentioned this issue Jan 23, 2024
Closed
9 tasks
@veenstrajelmer veenstrajelmer changed the title delete directory from download tests: https://docs.pytest.org/en/6.2.x/tmpdir.html use pytest tmp_dir instead of manually creating and deleting output folders Jan 23, 2024
@veenstrajelmer veenstrajelmer linked a pull request Jan 23, 2024 that will close this issue
removed all manual test dirs and replaced with tmp_path #735
Merged
@veenstrajelmer veenstrajelmer mentioned this issue Jan 23, 2024
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed all manual test dirs and replaced with tmp_path Deltares/dfm_tools
1 participant
@veenstrajelmer