Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slev obsdata download function #245

Closed
15 tasks done
veenstrajelmer opened this issue Feb 22, 2023 · 0 comments · Fixed by #711
Closed
15 tasks done

Add slev obsdata download function #245

veenstrajelmer opened this issue Feb 22, 2023 · 0 comments · Fixed by #711

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Feb 22, 2023

Todo:

  • download based on GTSM scripts with some updates
  • solve code duplicates, e.g. create standardized subsetting function instead of one for each dataset, same goes for downloading. But in that case the source has to be derived from the geodataframe.
  • x/y is generic because of geodataframe, also do for time_min/time_max/country
  • re-enable kwargs for catalog and dataretrieval (like gesla dir or drop_noncoastal stations)
  • add test cases
  • including export of resulting obspoints, e.g. to xynfile
  • drop non-geom lat/lon columns and non standard time columns
  • names of nc files should correspond to xynfile, so add unique stationname to all gdf's and use that column in writing nc and xyn. Also remove name_column argument in xyn function. Also add unique stationname to expected columns test.
  • possible to use gesla directly from zipfile or very bad for performance?
  • Add station_name/ndays to be generic across datasets (and add to test_ssh_catalog_subset())
  • check whether ioc contains more data than 1 day (first and last column seem to imply this)
  • expose public functions with from observations import *
  • check minimal required version for erddapy
  • example notebook (current example scripts in gtsm repos) >> result
  • update whatsnew.md

Follow-up: #712

@veenstrajelmer veenstrajelmer changed the title Add slev download function Add slev obsdata download function Jun 6, 2023
@veenstrajelmer veenstrajelmer linked a pull request Dec 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant