Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider recognizing deprecated keywords #668

Open
veenstrajelmer opened this issue Jul 5, 2024 · 0 comments
Open

Consider recognizing deprecated keywords #668

veenstrajelmer opened this issue Jul 5, 2024 · 0 comments
Labels
type: compatibility Changes needed to be compatible with the computational core

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jul 5, 2024

Is your feature request related to a problem? Please describe.
In #648 the FMModel and ResearchFMModel were updated to include all currently know research/GA keywords. However, there are several deprecated keywords registered in the FM kernel that are not recognized by HYDROLIB-core.

Describe the solution you'd like
It would be convenient if these keywords are filtered and a dedicated deprecation message would show up.

Additional context
Deprecated keywords registered in the FM kernel:

  • 'processes','dtmassbalance',DEPRECATED
  • 'geometry','bathymetryfile',OBSOLETE
  • 'geometry','bedlevelfile',OBSOLETE
  • 'geometry','botlevuni',OBSOLETE
  • 'geometry','botlevtype',OBSOLETE
  • 'geometry','ithindykescheme',OBSOLETE
  • 'geometry','manholefile',OBSOLETE
  • 'geometry','nooptimizedpolygon',OBSOLETE
  • 'numerics','hkad',OBSOLETE
  • 'numerics','ithindykescheme',OBSOLETE
  • 'numerics','thindykecontraction',OBSOLETE
  • 'numerics','transportmethod',OBSOLETE
  • 'numerics','transporttimestepping',OBSOLETE
  • 'output','writebalancefile',OBSOLETE
  • some of these (and others) are documented in A.4 of the FM user manual, new ones: geometry.ThindykeFile

Some deprecated keywords are not yet registered here, these should be added to both HYDROLIB-core and the FM kernel:

  • sobekdfm_umin >> renamed to Lateral_fixedweir_umin, but not in fm_deprecated_keywords.f90
  • sobekdfm_umin_method >> renamed to Lateral_fixedweir_umin_method, but not in fm_deprecated_keywords.f90
  • sobekdfm_minimal_1d2d_embankment >> deprecated, but not in fm_deprecated_keywords.f90
  • sobekdfm_relax >> deprecated, but not in fm_deprecated_keywords.f90
  • wridia_viscosity_diffusivity_limit >> deprecated, but not in fm_deprecated_keywords.f90
  • stericcorrection >> deprecated, but not in fm_deprecated_keywords.f90
  • wavenikuradse >> deprecated, but not in fm_deprecated_keywords.f90
@priscavdsluis priscavdsluis added the type: compatibility Changes needed to be compatible with the computational core label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: compatibility Changes needed to be compatible with the computational core
Projects
None yet
Development

No branches or pull requests

2 participants