-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support creation of databases in Firebird #1
Comments
@sungam3r and @mjauernig I always ended up implementing something like this when I have used DbUp. But its something you would only do in development or in temporary environments not in a "real" environment like production. So I am not sure it should be a part of DbUp - if so I think it should be a thing for all providers not firebird only. Today for local development I prefer to use a docker image to create the database - it is built into the https://hub.docker.com/r/jacobalberty/firebird image so then there is no reason to do it in DbUp. |
@sungam3r and @mjauernig Hmm... I can see that EnsureDatabase is already a part of DbUp-core so then my comment is not as valid. The PR DbUp/DbUp#365 has some of the same fixes I provided in DbUp/DbUp#692 |
@Jeern So we should merge DbUp/DbUp#365 to? |
@mjauernig No not before I have taken a look at it. According to the description it would conflict with what I have already done (perhaps not in GIT but functionally) |
Do you have any plans to support this? :) |
I have been out og the loop for a while so I don't know what the general plans are. I was working on a PR almost a year ago but got sidetracked by work. I really really hope I will be able to prioritize it in august. |
Yes, I think we should support this. |
I have implemented and tested this in a local branch. Just waiting for @droyad to give me permissions to push to dbup-firebird and create a PR (or tell me that I have to Fork ) |
I have pushed the branch but will wait for #7 to be merged before I create a PR (since I had to create the branch from that branch while waiting for Push permissions) |
Support creating databases with the
EnsureDatabase.For.FirebirdDatabase(connectionString);
call. I am working on implementing them. Hopefully a PR will follow soon.
The text was updated successfully, but these errors were encountered: