Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize file structure #7

Open
rsocci opened this issue Jul 12, 2016 · 1 comment
Open

Reorganize file structure #7

rsocci opened this issue Jul 12, 2016 · 1 comment

Comments

@rsocci
Copy link
Contributor

rsocci commented Jul 12, 2016

Currently, we have to test helper files:
helpers/interactions.js and helpers/finders.js

Goal:
Break up interactions.js into multiple files so that we have more specific groups of test helper files

Example:

  • helpers/finders.js
  • helpers/clickers.js
  • helpers/fillers.js
  • helpers/removeWhitespace.js (or should we avoid one function files?)
@michaeldupuisjr
Copy link
Contributor

I think breaking finders into a separate file makes sense, but I think breaking the interactions into the event type ("click" vs "fill in") might be too specific. It might not be intuitive when to create a dedicated file vs adding to an existing one (for example, if we want an interaction for selectFromDropdown(), would that be in the clickers.js or would we create a new select-based file?

This library is kind of based off of capybara-extensions, which breaks "nodes" down as follows: https://github.com/jnicklas/capybara/tree/55c2ec354276ad1a6f0376dd787f5d121117269b/lib/capybara/node

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants