Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge computeMsigOverlap and computeMsigNetwork #8

Open
ahmohamed opened this issue Oct 19, 2021 · 1 comment
Open

Merge computeMsigOverlap and computeMsigNetwork #8

ahmohamed opened this issue Oct 19, 2021 · 1 comment

Comments

@ahmohamed
Copy link
Member

Currently, having a list of significant gene sets, we compute the network using the following code:

gs_ovlap = computeMsigOverlap(siggs, thresh = 0.25)
gs_ovnet = computeMsigNetwork(gs_ovlap, msigdb)

I think we can't merge both into one function, with the signature

computeMsigNetwork <- function(siggs, thresh = 0.25) {
  gs_ovlap = computeMsigOverlap(siggs, thresh = 0.25)
  
  # This is the current computeMsigNetwork function
  # We reuse siggs, which is already a msigGsc object
  .computeMsigNetwork(gs_ovlap, siggs)
}

which will should make the code cleaner, and more black-boxed (if that's desirable).

@bhuvad
Copy link
Member

bhuvad commented Nov 7, 2021

The reason I left this separated was to enable independent analysis of the overlap data if users wish to do so. For instance, they can compute all pairwise overlaps (by setting thresh = 0) and then trying out a few filtering approaches manually. This would provide added flexibility without having to recompute overlaps every single time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants