Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/optimize code related to calculating the DefaultHashAlgorithms #100

Open
doulikecookiedough opened this issue Aug 20, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@doulikecookiedough
Copy link
Contributor

doulikecookiedough commented Aug 20, 2024

The default hash algorithms may change in the future, leading to required changes in FileHashStore and any classes that extend it.

This process should be refactored in such a way that we can simply change the default hash algorithms, without needing to touch any other affected code.

Additionally, I believe we could potentially optimize the process of calculating the checksums further in the method writeToTmpFileAndGenerateChecksums by removing some if statements.

Context:
It was initially refactored via Feature-95: HashStoreConverter & FileHashStoreLinks, however a junit test that was previously successfully was failing intermittently, as described here in this rollback PR, and respective issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant