Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the old URLs for six webinars don't match the new URLs created by Hugo #84

Open
robyngit opened this issue May 14, 2020 · 3 comments
Open
Assignees
Labels
bug Something isn't working website
Milestone

Comments

@robyngit
Copy link
Member

The way that Hugo sanitizes URLs (see gohugoio/hugo#4032) means that we have six webinars with URLs that don't match the URLs for the old website. This means that users who have bookmarked or linked to webinars with the old URL will end up with a 404 when the new website is launched. This may also have repercussions for transferring over the the Disqus Q&As (see issue #82). We might be able to resolve this by setting up re-directs with netlify.

Characters that cause the issue
, , , -–-

Fixes attempted
The following does not fix the problem:

  • entering the slug with encoding, e.g. hugo removes both %E2%80%99 and from the url
  • setting the URL in the front matter (see Hugo docs). Oddly, entering a URL with illegal characters means that the page is not rendered at all. hugo list all indicates that the page exists with a URL matching the one entered, but navigating to that page leads to a 404.

Example
The URL for the Dryad webinar on the old site is https://www.dataone.org/webinars/advancing-research-data-publishing-dryad%E2%80%99s-next-steps. In the slug field for the new version of the Dryad webianar, whether we enter advancing-research-data-publishing-dryad%E2%80%99s-next-steps or advancing-research-data-publishing-dryad’s-next-steps, hugo changes the resulting URL to https://preview.dataone.org/webinars/what-it-means-be-dataone-member-nodemember-nodes-share-their-views/. Navigating to https://preview.dataone.org/webinars/advancing-research-data-publishing-dryad%E2%80%99s-next-steps leads to a 404

The six problematic URLs

Slug as entered in the webinars slug field

[1] "advancing-research-data-publishing-dryad’s-next-steps"                               
[2] "dpm-“stack”-management-infrastructure-frame-digital-preservation-parallels-technical"
[3] "fair’er-data-through-semantics-nsf’s-dataone-and-arctic-data-center"                 
[4] "introduction-community-engagement-within-science-–-supporting-human-infrastructure"  
[5] "open-science-movement-mozilla’s-efforts-build-community-and-open-leadership-science" 
[6] "what-it-means-be-dataone-member-node—member-nodes-share-their-views"     

Slug in the old website

[1] "advancing-research-data-publishing-dryad%E2%80%99s-next-steps"                                       
[2] "dpm-%E2%80%9Cstack%E2%80%9D-management-infrastructure-frame-digital-preservation-parallels-technical"
[3] "fair%E2%80%99er-data-through-semantics-nsf%E2%80%99s-dataone-and-arctic-data-center"                 
[4] "introduction-community-engagement-within-science-%E2%80%93-supporting-human-infrastructure"          
[5] "open-science-movement-mozilla%E2%80%99s-efforts-build-community-and-open-leadership-science"         
[6] "what-it-means-be-dataone-member-node%E2%80%94member-nodes-share-their-views" 

How it's encoded with Hugo

[1] "advancing-research-data-publishing-dryads-next-steps"
[2] "dpm-stack-management-infrastructure-frame-digital-preservation-parallels-technical"
[3] "fairer-data-through-semantics-nsfs-dataone-and-arctic-data-center"
[4] "introduction-community-engagement-within-science-supporting-human-infrastructure"
[5] "open-science-movement-mozillas-efforts-build-community-and-open-leadership-science"
[6] "what-it-means-be-dataone-member-nodemember-nodes-share-their-views"
@robyngit robyngit added the bug Something isn't working label May 14, 2020
robyngit added a commit that referenced this issue May 26, 2020
@robyngit robyngit added the status: review Needs review before it can be closed label May 26, 2020
@robyngit
Copy link
Member Author

Added re-directs for these six webinars to the Netlify config file. These will need to be tested the next time we have Netlify re-build the site.

@robyngit robyngit added this to the MVP milestone May 26, 2020
@robyngit robyngit removed the blocker label May 26, 2020
@robyngit
Copy link
Member Author

robyngit commented Jun 9, 2020

These all work except for the first one, https://preview.dataone.org/webinars/advancing-research-data-publishing-dryad%E2%80%99s-next-steps still leads to a 404. This can likely be resolved when @datadavev sets up re-directs in issue #79 .

@robyngit
Copy link
Member Author

I'm re-opening this issue because the six webinar pages listed above need re-directs (#79).

For example, https://dataone.org/webinars/advancing-research-data-publishing-dryad’s-next-steps currently re-directs to the https://old.dataone.org/webinars/advancing-research-data-publishing-dryad%e2%80%99s-next-steps.
Instead, it should instead go to https://dataone.org/webinars/advancing-research-data-publishing-dryads-next-steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working website
Projects
None yet
Development

No branches or pull requests

3 participants