Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baggage headers not propagating #4055

Open
cchawn opened this issue Oct 31, 2024 · 3 comments
Open

baggage headers not propagating #4055

cchawn opened this issue Oct 31, 2024 · 3 comments
Assignees
Labels
bug Involves a bug community Was opened by a community member

Comments

@cchawn
Copy link

cchawn commented Oct 31, 2024

Current behaviour

baggage (and ot-baggage-*) headers are not being propagated through the system.

Expected behaviour

Based on the Trace Context Propagation documentation, the baggage headers should be automatically propagated?

Baggage propagation through OpenTelemetry’s W3C-compatible headers is enabled by default.

Perhaps I'm missing something ... but based on the documentation, it seems like this should "just work" 😅

Steps to reproduce

  1. Make a request to a service with DataDog tracing enabled
  2. Include a baggage or ot-baggage-* HTTP header in the request
  3. Notice that these headers do not get propagated to the rest of the system

Environment

  • datadog version: 2.4.0
  • Ruby version: 3.3.5

Additional context

It looks like at one point these headers were being propagated, see:

BAGGAGE_PREFIX = 'ot-baggage-'.freeze
BAGGAGE_PREFIX_FORMATTED = 'HTTP_OT_BAGGAGE_'.freeze

However, I can no longer find any references to "baggage" in the latest version.

Looking at other language libraries, they still include functionality to propagate these headers, for example: dd-trace-js

@cchawn cchawn added bug Involves a bug community Was opened by a community member labels Oct 31, 2024
@ZStriker19
Copy link
Contributor

Hi @cchawn ,

Thanks for reaching out. At the moment the Ruby tracer supports neither an OpenTracing or OpenTelemetry implementation of baggage. I think we previously removed the OpenTracing implementation since it's EOL. We do have plans to implement OpenTelemetry's baggage for Ruby as we are doing across other tracers, which is why you saw it in the docs, however it looks like we merged that docs update a bit too early as it's still in the works (we will fix this).

I'll update here as soon as baggage support is merged into the Ruby tracer.

@ZStriker19 ZStriker19 self-assigned this Nov 8, 2024
@boting
Copy link

boting commented Dec 2, 2024

Hi @ZStriker19 . Thanks for the added details and context. Have there been any updates that you can share?

@ZStriker19
Copy link
Contributor

Hi @boting I can't promise anything but it looks probable that this will be done in Q1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug community Was opened by a community member
Projects
None yet
Development

No branches or pull requests

3 participants