Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update warning message when defaulting to EXACT_MATCH_OPERATOR #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mateo-villa
Copy link

@mateo-villa mateo-villa commented Jan 24, 2025

What does this PR do?

Fixes a typo in the warning message shown to users.

Description of the Change

Previous warning message:

Defaulting to filter Operator `ExactMatch'. Please ensure the filter Value provided isupdated as this behavior will be removed in the future. See the official README for more information

After changes:

Defaulting to filter Operator `ExactMatch'. Please ensure the filter Value provided is updated as this behavior will be removed in the future. See the official README.md for more information.

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@mateo-villa mateo-villa requested a review from a team as a code owner January 24, 2025 20:26
@mateo-villa mateo-villa added the documentation Improvements or additions to documentation label Jan 24, 2025
Comment on lines +105 to +106
"Defaulting to filter Operator `ExactMatch'. Please ensure the filter Value provided is "
+ "updated as this behavior will be removed in the future. See the official README.md for more information."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Quality Violation

use f-string or .format to format strings (...read more)

Concatenation of multiple strings is not efficient and make the code hard to read and understand.

Instead of concatenating multiple strings, use an f-string or a format string.

Learn More

View in Datadog  Leave us feedback  Documentation

@mateo-villa mateo-villa linked an issue Jan 24, 2025 that may be closed by this pull request
@skarimo
Copy link
Member

skarimo commented Jan 28, 2025

Could you address the ruff failures surrounding the line length, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in EXACT_MATCH_OPERATOR warning message
2 participants