Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider providing a strong name for ClickHouse.Client #380

Open
osigurdson opened this issue Oct 26, 2023 · 2 comments
Open

Please consider providing a strong name for ClickHouse.Client #380

osigurdson opened this issue Oct 26, 2023 · 2 comments

Comments

@osigurdson
Copy link

See MSDN discussion here: https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming

@DarkWanderer
Copy link
Owner

Hi. Thank you for your suggestion - this seems like something relatively straightforward to implement. One point about versioning is slightly unclear to me - the article mentions:

CONSIDER incrementing the assembly version on only major version changes to help users reduce binding redirects, and how often they're updated

I assume you have experience with using strongly signed assemblies. How problematic would it be for users if AssemblyVersion updates with each release like it does now?

@osigurdson
Copy link
Author

Hello! I don't have experience with signing assemblies for broad consumption on nuget. I had a look at a few other projects (NodaTime, Log4Net, etc) and they appear to be using the and true in the csproj or within Directory.Build.props. The attribute matches what is on nuget and I believe the AssemblyVersion is getting updated as well. Some examples below.

Log4Net:
https://github.com/apache/logging-log4net/blob/master/src/log4net/log4net.csproj

NodaTime:
https://github.com/nodatime/nodatime/blob/main/Directory.Build.props

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants