Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Suggestion: Log File limits (to allow rotation) #150

Open
RobbieLePommie opened this issue Sep 8, 2022 · 1 comment
Open

Comments

@RobbieLePommie
Copy link
Contributor

Quick Description

If the server runs for a long time, the log file fills up and it never released to allow rotation or clean up.

Explanation

The "FileWriter" plugin opens a file when the server starts, and does not release its handle until the server stops. This can leave to out-of-space errors as the OS can never tidy/rotate the log files.

Other applications may start/stop the servers (e.g. Apache) to allow logs to be cleaned up, but that is not practical in this case.

The suggestion is to add "MaxFileSize" and "MaxTime" as optional limits to the FileLogger, thus allowing the server to release handles and the OS can then tidy.

It is noted that this could be done in another plugin, but this feature would presumably be useful to others, and is a "set and forget" bit of code; therefore I'm suggesting you can include this in the main repo.

Example usage:

All settings optional.

@RobbieLePommie
Copy link
Contributor Author

Added as pull request.

#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant