Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.4 support #109

Closed
Viktor-Ivliev opened this issue Jan 9, 2025 · 5 comments
Closed

Ruby 3.4 support #109

Viktor-Ivliev opened this issue Jan 9, 2025 · 5 comments

Comments

@Viktor-Ivliev
Copy link

The parser has been changed in ruby 3.4 , maybe you should use it (Prism)

Right now we're getting this:
NOTE: RubyParser::V34 undefined, using RubyParser::V33

@DamirSvrtan
Copy link
Owner

Hi Viktor,

Do you wanna try to give it a shot and perform the upgrade? (and add 3.4 to the testing matrix?)

@Viktor-Ivliev
Copy link
Author

Due to my busy work schedule 😢 , I'm not sure about this. But I can try to fix this class for the weekend:
lib/fasterer/parser.rb
Apparently we need to add a ruby version-dependent parser and corresponding tests.

@Viktor-Ivliev
Copy link
Author

It looks like they strongly gems return colossally different parsing structures, and this gem is very focused on the result of what ruby parser will return, so if we do backwards compatibility it's a huge job with no way back.
So we will wait for ruby_parser to make support for 3.4. Especially since the gem is independent of the ruby kernel, and parses data for its own needs. It was a cool experience that stumped me.

The task can be buried if you think no one will continue it.

@Viktor-Ivliev
Copy link
Author

@Viktor-Ivliev
Copy link
Author

@DamirSvrtan maybe sometime in the future the map { it } metric will be added. 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants