From 7c49db1b8368fe40b90b70764b6b308205b4467e Mon Sep 17 00:00:00 2001 From: Dale Seo Date: Fri, 6 Sep 2024 19:19:10 -0400 Subject: [PATCH 1/5] refactor: language section does not use slots --- components/language-section.js | 44 ++++++++++++++++++++++++---------- index.html | 35 +-------------------------- 2 files changed, 33 insertions(+), 46 deletions(-) diff --git a/components/language-section.js b/components/language-section.js index f4306ee..d22d7db 100644 --- a/components/language-section.js +++ b/components/language-section.js @@ -76,34 +76,34 @@ class LanguageSection extends HTMLElement { } } - ::slotted([slot="mobile-image"]) { + #mobile-image { display: block; } - ::slotted([slot="tablet-image"]) { + #tablet-image { display: none; } - ::slotted([slot="desktop-image"]) { + #desktop-image { display: none; } @media only screen and (min-width: 768px) { - ::slotted([slot="mobile-image"]) { + #mobile-image { display: none; } - ::slotted([slot="tablet-image"]) { + #tablet-image { display: block; } } @media only screen and (min-width: 1024px) { - ::slotted([slot="tablet-image"]) { + #tablet-image { display: none; } - ::slotted([slot="desktop-image"]) { + #desktop-image { display: block; } } @@ -114,16 +114,36 @@ class LanguageSection extends HTMLElement { return html`
- - + 지역에 관계없이 다양한 언어로 참여할 수 있어요. + + 참여방법 안내 +
`; diff --git a/index.html b/index.html index f9c6a3f..692d55b 100644 --- a/index.html +++ b/index.html @@ -48,40 +48,7 @@ - - - - - - 지역에 관계없이 다양한 언어로 참여할 수 있어요. - - - 참여방법 안내 - - + From b769ba89a7a567b1242766a2dd89507e23f48ae2 Mon Sep 17 00:00:00 2001 From: Dale Seo Date: Fri, 6 Sep 2024 19:21:54 -0400 Subject: [PATCH 2/5] refactor: participant review section does not use slots --- components/participant-review-section.js | 61 ++++++++++++++++++++++- index.html | 63 +----------------------- 2 files changed, 61 insertions(+), 63 deletions(-) diff --git a/components/participant-review-section.js b/components/participant-review-section.js index b7bfeb9..e596d24 100644 --- a/components/participant-review-section.js +++ b/components/participant-review-section.js @@ -33,7 +33,66 @@ class ParticipantReviewsSection extends HTMLElement { createHtml() { return html`
- + 참가자 후기 + + + + + + + + +
`; } diff --git a/index.html b/index.html index 692d55b..7ec275a 100644 --- a/index.html +++ b/index.html @@ -52,68 +52,7 @@ - - 참가자 후기 - - - - - - - - - - + From a8b52986a88da7e99af62e615fc3643e9b4d39fd Mon Sep 17 00:00:00 2001 From: Dale Seo Date: Fri, 6 Sep 2024 19:26:14 -0400 Subject: [PATCH 3/5] refactor: footer does not use slots --- components/footer.js | 18 ++++++++++-------- index.html | 6 +----- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/components/footer.js b/components/footer.js index 480455d..dbc2612 100644 --- a/components/footer.js +++ b/components/footer.js @@ -78,14 +78,16 @@ class Footer extends HTMLElement { } createHtml() { - return html`
-
- - -
- -

© 2024 DaleStudy. All rights reserved.

-
`; + return html` +
+
+ + +
+ +

© 2024 DaleStudy. All rights reserved.

+
+ `; } } diff --git a/index.html b/index.html index 7ec275a..38e8b5c 100644 --- a/index.html +++ b/index.html @@ -56,10 +56,6 @@ - - - - - + From 30331c2858f68fcd826e2fac2f8d47afaa6b73a7 Mon Sep 17 00:00:00 2001 From: Dale Seo Date: Fri, 6 Sep 2024 19:29:15 -0400 Subject: [PATCH 4/5] chore: remove unncessary id on intro section --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index 38e8b5c..a99cd53 100644 --- a/index.html +++ b/index.html @@ -46,7 +46,7 @@ - + From c6b4c7f8135b09c46ad54d202413b06b58ca7131 Mon Sep 17 00:00:00 2001 From: Dale Seo Date: Fri, 6 Sep 2024 19:32:57 -0400 Subject: [PATCH 5/5] chore: remove the FOUC hack --- index.html | 4 ++-- main.js | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) delete mode 100644 main.js diff --git a/index.html b/index.html index a99cd53..46abf82 100644 --- a/index.html +++ b/index.html @@ -40,10 +40,10 @@ /> - + - + diff --git a/main.js b/main.js deleted file mode 100644 index b180ff7..0000000 --- a/main.js +++ /dev/null @@ -1,5 +0,0 @@ -import "./components/index.js"; - -document.addEventListener("DOMContentLoaded", () => { - document.querySelector("body").style.display = "block"; -});