-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Johnfreeman/129 update dependencies #169
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs in not only pybind11 but also moo, and only have an explicit (run-time) dependence on moo if python configuration is used in a package
…nly if they're only used in unit tests)
…hat's actually available on the web
…n we're dealing with a developer installation
…kage, which lets you choose whether you want to include developer tools (daq-cmake, cmake, etc.)
…s needed when generating configs, come up with a ~dev version of daq-cmake which can still provide this while not bringing in its dependencies
…installation of dunedaq will work
Conflicts: spack-repos/release-repo-template/packages/cmdlib/package.py spack-repos/release-repo-template/packages/dfmessages/package.py spack-repos/release-repo-template/packages/dfmodules/package.py spack-repos/release-repo-template/packages/dqm/package.py spack-repos/release-repo-template/packages/serialization/package.py spack-repos/release-repo-template/packages/sspmodules/package.py spack-repos/release-repo-template/packages/timing/package.py spack-repos/release-repo-template/packages/trigger/package.py
…the possibly-unavailable sh module
…variant of daq-cmake
… machines at CERN, but is now part of the standard docker installation
…eflect updated dependencies
changed target release to 3.1.0 since it requires longer time for building and testing. |
Conflicts: spack-repos/release-repo-template/packages/appfwk/package.py
…nctions (daq_add_python_bindings, etc.) only depend on daq-cmake in the build phase
…_model_path function where necessary
… daq-cmake is built, but IS needed by other packages which use it
…pybind11 and py-moo
… under the ~dev option
…the Python virtual environment and thus doesn't need to be specified as a Spack run-time dependency
…nt of externals continue to not depend on devtools, but regardless still depend on the systems umbrella package (needed for openssh and parts of gcc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To summarize where the code is at, when
make-release-repo.py
is run it'll do the following:dunedaq
umbrella package which has a+dev
and~dev
variant.~dev
leaves outdevtools
, which means thatgdb
andninja
are left outdaq-cmake
now depends oncmake
,py-moo
, andpy-pybind11
as its functions rely on thesedaq-cmake
, but only have a "build" dependency on it~dev
installation,dunedaq
still depends ondaq-cmake
, since theget_moo_model_path
function in itsenv.py
module is always neededboost
is "build"-only in a package if boost is only used for unit testsmake-release-repo.py
; they're set to an official documentation page if available, and if not, to a GitHub page