Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes & Addressing the Issues Board #2107

Closed
wants to merge 16 commits into from

Conversation

JakeDaBoss
Copy link
Contributor

@JakeDaBoss JakeDaBoss commented May 23, 2022

Closes #2071
Closes #2074

Crisis Time from 60 to 20 minutes.

@JakeDaBoss JakeDaBoss marked this pull request as draft May 23, 2022 22:42
@JakeDaBoss JakeDaBoss changed the title Marker stuff Bug Fixes & Addressing the Issues Board May 23, 2022
JakeDaBoss added 12 commits May 24, 2022 00:59
Adjusts amount of available Engineering RIGs from 5 to 3. Removed from lockers and added to protected racks.

Adjusts amount of available Security RIGs to 2 in protected racks.

Adjusts engineering rigs to be 100% resistant to radiation (seems a bit silly otherwise).
I don't know where those are right now, so won't map those in.
Slightly better with more advanced rig modules in comparison to its found counterpart for testing purposes. Price increased 10%. Store variant has hotswap too, the found version does not.

Adjusted the patrol rig found variant to be inherently inferior to the store version.
Significantly increased price. Store variant is now better than the found one, with a hotswap and advanced modules of the originally available ones.
Vintage RIG now has two new subtypes for the heavy and regular variant to go into the store.

Inherently better, and price increased.
Advanced Rig now has a new subtype (again). Inherently better. Price increased by 10%.

Mining RIG as FOUND (so, spawning in locker i.e.) has a 15% reduction in all stats, as "worn" or "used". Give that a name. It's been used, its damage protection has degraded.

Mining RIG as BOUGHT is brand new and has a 10% reduction as opposed to the prior stats. Bought WILL be better than found. BOUGHT also has better modules in general. Advanced healthbar and heavy storage.
Inherently better. Price increased by 15%.
Copy link
Collaborator

@DTraitor DTraitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge your changelog files into one, some things weren't commented in this review, they will be discussed with West since those are probably his requests

code/game/objects/random/loot.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/rig/suits/advanced.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/rig/suits/ce.dm Outdated Show resolved Hide resolved
code/modules/clothing/spacesuits/rig/suits/patrol.dm Outdated Show resolved Hide resolved
build_path = /obj/item/weapon/rig/riot
price = 15000
build_path = /obj/item/weapon/rig/riot/store
price = 20000 // Currently the beefiest thing we've got. Veeeery expensive.
Copy link
Collaborator

@DTraitor DTraitor May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the best RIG, it depends on what you need

maps/DeadSpace/M.04 Ishimura (M).dmm Outdated Show resolved Hide resolved
maps/DeadSpace/M.04 Ishimura (M).dmm Outdated Show resolved Hide resolved
maps/DeadSpace/M.04 Ishimura (M).dmm Outdated Show resolved Hide resolved
@DTraitor
Copy link
Collaborator

(Yes, I reviewed a draft PR)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Used by github workflow, do not edit label Jun 2, 2022
Isn't used as often because of RIGs, compact is where it's at now if we want to give any chance of revival.
@JakeDaBoss JakeDaBoss marked this pull request as ready for review June 4, 2022 15:38
@github-actions github-actions bot closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Used by github workflow, do not edit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE ADJ: RIG Balancing and Availability FEATURE ADJ: Adjusting Crisis Time
2 participants