-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
download libspdm code and its submodules twice #148
Comments
9/19/2022 - The solution is to move https://github.com/DMTF/spdm-emu/tree/main/spdm_emu/spdm_device_validator_sample to https://github.com/DMTF/SPDM-Responder-Validator |
Hi. When move spdm_emu/spdm_device_validator_sample to DMTF/SPDM-Responder-Validator, there are many code depend on spdm-emu. spdm-emu/spdm_emu/spdm_device_attester_sample/CMakeLists.txt Lines 18 to 23 in 32bdd5e
spdm-emu/spdm_emu/spdm_device_attester_sample/spdm_device_attester_sample.h Lines 12 to 17 in 32bdd5e
The independent DMTF/SPDM-Responder-Validator will not build successful without these code/lib support. |
Fix the issue: DMTF#148 Make the SPDM-Responder-Validator independent. The SPDM-Responder-Validator will not be submodule after this PR. Signed-off-by: Wenxing Hou <[email protected]>
Fix the issue: DMTF#148 Signed-off-by: Wenxing Hou <[email protected]>
Fix the issue: DMTF#148 Make the SPDM-Responder-Validator independent. The SPDM-Responder-Validator will not be submodule after this PR. Signed-off-by: Wenxing Hou <[email protected]>
Fix the issue: DMTF#148 Signed-off-by: Wenxing Hou <[email protected]>
Fix the issue: DMTF#148 Make the SPDM-Responder-Validator independent. The SPDM-Responder-Validator will not be submodule after this PR. Signed-off-by: Wenxing Hou <[email protected]>
Fix the issue: DMTF#148 Signed-off-by: Wenxing Hou <[email protected]>
Look at DMTF/SPDM-Responder-Validator#36. It seems too many changes. @steven-bellock , should we consider move below to libspdm ?
Still thinking what is the best way to organize those libraries. Let's discuss in the meeting. |
When use "git submodule update --init --recursive" command to get the full repo, the libspdm code and its submodules will download twice.
The files in SPDM-Responder-Validator/libspdm directory are not necessary to build the spdm-emu executable files.
The text was updated successfully, but these errors were encountered: