Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current construction of rib geometry sometimes leads to non-planar ribs. #1020

Open
AntonReiswich opened this issue Aug 16, 2024 · 0 comments

Comments

@AntonReiswich
Copy link
Contributor

AntonReiswich commented Aug 16, 2024

The current construction of the geometry of a rib allows ribs to be non-flat.

This is not intended as for example shows in the error message thrown in CCPACSWingCell.cpp within the function body of CCPACSWingCell::CutSpanwise.

The reason for this:
The function CCPACSWingRibsDefinition::BuildRibCutFace can return a non-flat face, since its construction is based on an interpolation of potentially windswept wires (local variables within the function's body: cutFaceFrontWire and cutFaceFrontWire).
The reason why these wires might be windswept, lies in the fact that the vectors used for its construction, that are handed over to the function CCPACSWingRibsDefinition::BuildRibCutFace via the arguments upVecStart, and upVecEnd, are constructed with the function CCPACSWingRibsDefinition::GetRibUpVector in an incorrect way: the problem with this function is that its local variable cutPlaneNormal is a vector that might have different directions at the first spar and the last spar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant