Uninstall does not remove LV2 folders #83
Comments
|
I am not used to uninstall steps in meson. |
|
I could certainly try to find a solution. Could you give me a hint where in the code would I look? I am completely unfamiliar with meson. |
|
@alex-tee any hints? I guess you are the most familiar with meson. |
|
perhaps this? |
|
meson only deletes files it knows about (like custom_target(), executable() etc.) so my guess is that it doesnt know that it created those directories, but I need to look at the build configs again to check what this does |
|
Can you post the contents of |
|
oddly enough it does remove the folders from |
|
According to the install log, meson never created any directories. Are you absolutely positive that they did not exist when you ran meson install? |
|
100% certain, and I tested to make sure |
|
@eli-schwartz my apologies.... this is the correct output of perhaps this will help output from |
|
in the example for the installation/removal of vitalium.vst3 and vitalium.lv2 uninstall for the VST3 removes the one file and at the end after all the LV2 files have been removed proceeds to one by one remove the folders for VST3, for LV2 removes the files but after all is said and done does not consider the LV2 folder for removal perhaps it is because there are more than one file being written to the LV2 folders that the uninstall is missing them? |
|
It's not clear to me... Is the original install-log.txt the same one that corresponds to the latest ninja-install.txt and ninja-uninstall.txt ? |
|
initially I uploaded the wrong file for uninstall, I replaced it with a good one, the install file was OK |
|
Again, this does not list /usr/local/lib/vst3 or /usr/local/lib/lv2 So, those directories do not get deleted. However, it does list As you can see, the uninstall log lists: So, meson is uninstalling the folders it creates. However, there are one or two folders that meson believes it did not create (either because you ran ninja install twice in a row, and the second run which did not create any directories overwrote the first log, or, because you have other pre-existing software there), therefore it is not trying to uninstall them. |
|
I tried a fresh clone and same result here are the steps
now the DISTRHO-Ports are installed after running
folders remain |
|
for reference, the *.lv2 dirs are generated and installed using this
`custom_target()`:
https://github.com/DISTRHO/DISTRHO-Ports/blob/52efe75c693ee567142212c505dd19568f01c458/ports/meson.build#L220
…On 17.03.2021 06:03, tank-trax wrote:
I tried a fresh clone and same result
here are the steps
git clone https://github.com/DISTRHO/DISTRHO-Ports.git
meson build --buildtype release
ninja -C build
usr/local/lib/lv2/ has no folders in it with anything from
DISTRHO-Ports
[1]
ninja -C build install
[2]
now the DISTRHO-Ports are installed
after running ninja -C build uninstall
[3]
folders remain
--
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [4], or unsubscribe
[5].
Links:
------
[1]
https://user-images.githubusercontent.com/41337033/111416886-2902fc80-86bb-11eb-8a7b-a98f478f3c31.png
[2]
https://user-images.githubusercontent.com/41337033/111417389-25bc4080-86bc-11eb-92a0-70623ebe1d47.png
[3]
https://user-images.githubusercontent.com/41337033/111417301-f574a200-86bb-11eb-9117-c87540f7f19b.png
[4]
#83 (comment)
[5]
https://github.com/notifications/unsubscribe-auth/AAZ76JYLHOIFOL3CHTDOQ5TTEAZ3TANCNFSM4ZJHCLUQ
|
My install log: Uninstall: |
|
FWIW, while I still cannot reproduce your issue you did lead me to discover another one -- I have a case where |
|
try -Dbuild-lv2=true
for an LV2 there are 3 or 4 files written per folder my guess is that whenever meson is writing to the target folder and creates the |
|
My goal in only enabling part of the build was to create a reasonably reproducible test case demonstrating a subset of this repo, which doesn't go even further past 600MB as that was quite bloated on its own. I don't have endless time and compute to spend on this. And I'm fairly sure none of this should matter. I found and fixed one case where meson neglected to do its usual tracking of installed directories, but in general the principle is sound and should work. (And no, creating the same directory multiple times won't mess up install tracking... mainly because Side note: you're welcome to try meson from eli-schwartz/meson@f7b0238 (now merged to meson git master) and see if that somehow fixes the problem for you. I don't think it is your exact issue, but you never know. |
|
You can build only specific plugins, so that it takes less time. |
By not building the LV2 you are not reproducing the issue |
|
I'm not playing this game. If you'd like me to go out of my way to try to reproduce your bug, give me a minimal test case that you have verified causes a problem on your end. I'm not building this multiple GB kitchen sink repo with all the everything enabled because you're not sure whether it matters. I tried to make a point. The point has not been accepted. If you want a better point out of me (or to convince me that meson has another edge case) you'll need to work with me here. |
|
I've will repeat again... when installing without any switches following the instructions.... when the uninstall is invoked folders will remain in I am having a hard time understanding why you cannot grasp this on a personal level it doesn't affect me because I have a workaround solution plus the '--prefix=' provides a good place to deposit the builds ... but not everybody is able to figure out workarounds this no longer affects me... as you don't want to test it properly I will close this ticket |
|
issue is still present, so please leave the ticket open. is this issue reproducible with a smaller build? we can check for that first. again, we can use this to build only 1 plugin: |
This is too big of a test case for me and I'm personally not interested in helping to debug meson issues for builds of that size. If the minimal build which @falkTX has mentioned twice now, can reproduce your issue -- or if you can distill a small test case in a similar manner -- then that would help greatly. It's not fun to try to reproduce a bug when the reproducible test case is gigabytes large and has well over 500 translation units. I don't even use this software... I'm interested in this from the meson side of things. |
running
sudo ninja -C build uninstalldoes not delete the following folders:
also, I was wondering could there be a switch or is there one to install/uninstall locally into
~./lv2The text was updated successfully, but these errors were encountered: