Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vm_destroy_pagetable do something more sensible to enable proper userland process/thread clean-up #26

Open
oleks opened this issue Apr 3, 2016 · 2 comments
Open

Make vm_destroy_pagetable do something more sensible to enable proper userland process/thread clean-up #26

oleks opened this issue Apr 3, 2016 · 2 comments
Labels
enhancement
Milestone
CompSys 2016

Comments

@oleks
Copy link
Member

oleks commented Apr 3, 2016

No description provided.

@oleks oleks added this to the CompSys 2016 milestone Apr 3, 2016
@athas
Copy link
Contributor

athas commented Apr 3, 2016

vm_unmap() is not needed - what is needed is giving the pages in the
to-be-destroyed pagetable back to the physical page pool. That is not
necessarily the same as unmapping. Consider the case of the same
physical page being mapped in several page tables.

\ Troels
/\ Henriksen

@oleks
Copy link
Member Author

oleks commented Apr 3, 2016

On Sun, Apr 3, 2016 at 1:26 PM, Troels Henriksen [email protected]
wrote:

vm_unmap() is not needed - what is needed is giving the pages in the
to-be-destroyed pagetable back to the physical page pool. That is not
necessarily the same as unmapping. Consider the case of the same
physical page being mapped in several page tables.

True. So this is really a bug in vm_destroy_pagetable?

@oleks oleks changed the title Implement vm_unmap to enable proper userland process/thread clean-up. Make vm_destroy_pagetable do something more sensible to enable proper userland process/thread clean-up Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
CompSys 2016
Development

No branches or pull requests
2 participants
@athas @oleks