Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better description of attributes in code #31

Open
parfa30 opened this issue Sep 14, 2020 · 4 comments
Open

Better description of attributes in code #31

parfa30 opened this issue Sep 14, 2020 · 4 comments
Assignees

Comments

@parfa30
Copy link
Contributor

parfa30 commented Sep 14, 2020

Describe the bug
Not a bug, just a series of recommendations by @dey3434 for better description of attributes throughout the Intro and WhiteDwarf notebooks. code would be easier to understand with more comments and definitions of terms

Comments
Intro Notebook:

  • output 84: what is z?

White Dwarfs Notebook:

  • In second text box: "We're all familiar with our own sun a seemingly ever present that we see continually day to day"--missing a word
  • unnecessary capitalization of "Helium" in third text box
  • what are mag. errors?
  • what is the y axis for out [12]? is it flux?
  • "Given 'standard' stars, those with external distance constraints we can also" missing comma
  • explanation of flux needed
@michaelJwilson
Copy link
Contributor

@alxogm We won't get this in for the release tomorrow, but trialing assigning someone to make sure the Spanish is updated in tandem.

@parfa30 If you commit one notebook at a time to your fork, I'll try and keep up. That way we can converge on any style changes before a lot is done.

@dey3434 Feel free to take part! Let us know if you need help with getting started with Git. We do ask that you upload a photo to Git first, if you're going to contribute. Get permission from your parents if you're still a minor!

Thanks!

@michaelJwilson
Copy link
Contributor

I'm curious if @dey3434 is still taking a stab at these / made it to the finish? @parfa30

@dey3434
Copy link

dey3434 commented Dec 15, 2020 via email

@michaelJwilson
Copy link
Contributor

No problem, that'd be great! We're still in development of the material and transitioning to a Berkeley Extensions course that would have a test and yield college credits. There's still some work to do in forming a semi-complete picture and gauging the right level of difficulty. It'd likely be useful to have a short chat, probably before and after looking at any more notebooks - assuming Arjun etc. is good with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants