Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the rate constants in batch #6

Closed
jiweiqi opened this issue May 17, 2020 · 0 comments
Closed

Evaluate the rate constants in batch #6

jiweiqi opened this issue May 17, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jiweiqi
Copy link
Contributor

jiweiqi commented May 17, 2020

for i in range(self.n_reactions):

Currently, in order to avoid in-place operation, we iteratively evaluate the forward rates by looping the reactions. It seems that we can evaluate it in matrix form by some careful coding without in-place operation. Initial thoughts are having a mask to evaluate the normal reactions in batch and the pressure-dependent reaction iteratively. Since the pressure-dependent reactions are usually only a small portion, and related to C0-C1 core mechanism.

@jiweiqi jiweiqi added the enhancement New feature or request label May 17, 2020
@jiweiqi jiweiqi changed the title Evaluate the rate constants without iteration Evaluate the rate constants in batch Jul 1, 2020
ZhiyuShi added a commit that referenced this issue Jul 5, 2020
@jiweiqi jiweiqi closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants