From ab3b491a67b8475b2cd031626b3f4c65aa3a5a6d Mon Sep 17 00:00:00 2001
From: Stuart Adair <43574728+StuAA78@users.noreply.github.com>
Date: Wed, 9 Oct 2024 15:04:21 +0100
Subject: [PATCH 1/2] Add `navigation` role to login/sign-in div

---
 packages/webapp/src/views/common/signin-nav.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/webapp/src/views/common/signin-nav.html b/packages/webapp/src/views/common/signin-nav.html
index 97d9327077..5087422607 100644
--- a/packages/webapp/src/views/common/signin-nav.html
+++ b/packages/webapp/src/views/common/signin-nav.html
@@ -1,4 +1,4 @@
-<div id="profile" class="login-nav">
+<div id="profile" class="login-nav" role="navigation">
   <ul class="login-nav__list">
     <li class="login-nav__list-item">{{ auth.firstName }} {{ auth.lastName }} |{% if auth.representing %} (representing {{ auth.representing }}){% endif %}</li>
     <li class="login-nav__list-item"><a id="link-manage-account" href="/manage-biodiversity-gains" class="govuk-link login-nav__link govuk-link--no-visited-state">Manage biodiversity gains</a> |</li>

From bc8f913df68184c71ae47a4000d3c3ec0e75f73d Mon Sep 17 00:00:00 2001
From: Stuart Adair <43574728+StuAA78@users.noreply.github.com>
Date: Wed, 9 Oct 2024 16:55:29 +0100
Subject: [PATCH 2/2] Change div to nav element as per sonarcloud feedback

---
 packages/webapp/src/views/common/signin-nav.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/webapp/src/views/common/signin-nav.html b/packages/webapp/src/views/common/signin-nav.html
index 5087422607..ab4f039f74 100644
--- a/packages/webapp/src/views/common/signin-nav.html
+++ b/packages/webapp/src/views/common/signin-nav.html
@@ -1,7 +1,7 @@
-<div id="profile" class="login-nav" role="navigation">
+<nav id="profile" class="login-nav" role="navigation">
   <ul class="login-nav__list">
     <li class="login-nav__list-item">{{ auth.firstName }} {{ auth.lastName }} |{% if auth.representing %} (representing {{ auth.representing }}){% endif %}</li>
     <li class="login-nav__list-item"><a id="link-manage-account" href="/manage-biodiversity-gains" class="govuk-link login-nav__link govuk-link--no-visited-state">Manage biodiversity gains</a> |</li>
     <li class="login-nav__list-item"><a id="link-sign-out" href="/signout" class="govuk-link login-nav__link govuk-link--no-visited-state">Sign out</a></li>
   </ul>
-</div>
\ No newline at end of file
+</nav>
\ No newline at end of file