Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CyberSource.Authentication has dependency on NUnit. Is this neccessary? #187

Open
le-dhogan opened this issue Sep 18, 2024 · 2 comments
Open

Comments

@le-dhogan
Copy link

This library has a dependency on CyberSource.Authentication which has a nuget project url of https://github.com/CyberSource/cybersource-rest-auth-dotnet

This project repo returns a 404 so I'm assuming it's a private / closed source project? Is this intentional?

My issue is that CyberSource.Authentication has a dependency on
NUnit (>= 3.10.1)
Is there a reason for this library bundling a Test Framework?

Thanks

@le-dhogan
Copy link
Author

Thanks @spx-mw - very useful to see this netstandard source!
The project file you linked is the actual Test project so expect NUnit usage usage in that.

Interestingly though, https://github.com/CyberSource/cybersource-rest-client-dotnetstandard/blob/master/cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/AuthenticationSdk.csproj doesn't seem to have NLog reference.
This is versioned as v0.0.1.14 whereas the published latest package for this is v0.0.0.20.

Seems that anyone referencing CyberSource.Rest.Client or CyberSource.Authentication is being forced to bring in NUnit and it feels like this should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants