From 14f24679d661af1ae03ac1ebf65e1007be6e51ea Mon Sep 17 00:00:00 2001 From: Rob Lucha Date: Mon, 21 Oct 2024 18:47:29 +0100 Subject: [PATCH 1/2] fix: conform to mandatory definitionId contract --- src/api.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/api.ts b/src/api.ts index 5f7bf44..1122499 100644 --- a/src/api.ts +++ b/src/api.ts @@ -184,7 +184,7 @@ export default class FalconApi { operationId, }: { operationId: string; - definitionId?: string; + definitionId: string; }) { assertConnection(this); @@ -194,7 +194,7 @@ export default class FalconApi { const apiIntegration = new ApiIntegration(this, { operationId, - definitionId: definitionId ?? this.data?.app.id, + definitionId: definitionId, }); this.apiIntegrations.push(apiIntegration); From 0550a4e3a294d2e3b1a1e41f20d922f29b233a1d Mon Sep 17 00:00:00 2001 From: Rob Lucha Date: Tue, 22 Oct 2024 09:43:53 +0100 Subject: [PATCH 2/2] chore: add changeset --- .changeset/mighty-tigers-sing.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/mighty-tigers-sing.md diff --git a/.changeset/mighty-tigers-sing.md b/.changeset/mighty-tigers-sing.md new file mode 100644 index 0000000..65ddc81 --- /dev/null +++ b/.changeset/mighty-tigers-sing.md @@ -0,0 +1,5 @@ +--- +'@crowdstrike/foundry-js': minor +--- + +Enforce mandatory definitionID for API Integration calls