From b3b4b800d38522c3c977c2fd6e1930b774c74f77 Mon Sep 17 00:00:00 2001 From: Brad Aune Date: Wed, 27 Nov 2024 08:20:45 -0500 Subject: [PATCH] fix: PR feedback --- packages/ember-toucan-form/package.json | 2 +- packages/ember-toucan-form/src/components/toucan-form.gts | 2 +- pnpm-lock.yaml | 8 +++----- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/ember-toucan-form/package.json b/packages/ember-toucan-form/package.json index 4c801f488..72e68b18e 100644 --- a/packages/ember-toucan-form/package.json +++ b/packages/ember-toucan-form/package.json @@ -45,7 +45,6 @@ "dependencies": { "@babel/runtime": "^7.20.7", "@embroider/addon-shim": "^1.0.0", - "ember-async-data": "^1.0.3", "ember-modifier": "^4.1.0" }, "devDependencies": { @@ -90,6 +89,7 @@ "@typescript-eslint/parser": "^5.30.5", "autoprefixer": "^10.0.2", "concurrently": "^8.0.0", + "ember-async-data": "^1.0.3", "ember-cli-htmlbars": "^6.1.1", "ember-headless-form": "^1.0.0-beta.3", "ember-source": "~5.12.0", diff --git a/packages/ember-toucan-form/src/components/toucan-form.gts b/packages/ember-toucan-form/src/components/toucan-form.gts index b49313adc..58a0129f0 100644 --- a/packages/ember-toucan-form/src/components/toucan-form.gts +++ b/packages/ember-toucan-form/src/components/toucan-form.gts @@ -2,7 +2,6 @@ import Component from '@glimmer/component'; import { hash } from '@ember/helper'; import { HeadlessForm } from 'ember-headless-form'; -import { TrackedAsyncData } from 'ember-async-data'; import AutocompleteFieldComponent from '../-private/autocomplete-field'; import CheckboxFieldComponent from '../-private/checkbox-field'; @@ -15,6 +14,7 @@ import TextareaFieldComponent from '../-private/textarea-field'; import type { HeadlessFormBlock, UserData } from '../-private/types'; import type { WithBoundArgs } from '@glint/template'; +import type { TrackedAsyncData } from 'ember-async-data'; import type { ErrorRecord } from 'ember-headless-form'; import type { HeadlessFormComponentSignature } from 'ember-headless-form/components/headless-form'; diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 8aa3b3b22..2e9db9521 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -564,9 +564,6 @@ importers: '@embroider/addon-shim': specifier: ^1.0.0 version: 1.8.4 - ember-async-data: - specifier: ^1.0.3 - version: 1.0.3(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)) ember-modifier: specifier: ^4.1.0 version: 4.1.0(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)) @@ -694,6 +691,9 @@ importers: concurrently: specifier: ^8.0.0 version: 8.2.2 + ember-async-data: + specifier: ^1.0.3 + version: 1.0.3(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)) ember-cli-htmlbars: specifier: ^6.1.1 version: 6.3.0 @@ -12369,7 +12369,6 @@ snapshots: '@ember/test-helpers': 3.3.1(@babel/core@7.26.0)(@glint/template@1.5.0)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)(webpack@5.96.1))(webpack@5.96.1) '@embroider/addon-shim': 1.8.4 '@glimmer/tracking': 1.1.2 - ember-async-data: 1.0.3(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)) ember-headless-form: 1.1.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glimmer/tracking@1.1.2)(@glint/environment-ember-loose@1.5.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(@types/ember__array@4.0.10(@babel/core@7.26.0))(@types/ember__component@4.0.22(@babel/core@7.26.0))(@types/ember__controller@4.0.12(@babel/core@7.26.0))(@types/ember__object@4.0.12(@babel/core@7.26.0))(@types/ember__routing@4.0.22(@babel/core@7.26.0))(ember-cli-htmlbars@6.3.0)(ember-modifier@4.1.0(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5))))(@glint/template@1.5.0)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)) ember-modifier: 4.1.0(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)) ember-source: 5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)(webpack@5.96.1) @@ -12386,7 +12385,6 @@ snapshots: '@ember/test-helpers': 3.3.1(@babel/core@7.26.0)(@glint/template@1.5.0)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)(webpack@5.96.1))(webpack@5.96.1) '@embroider/addon-shim': 1.8.4 '@glimmer/tracking': 1.1.2 - ember-async-data: 1.0.3(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)) ember-headless-form: 1.1.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glimmer/tracking@1.1.2)(@glint/environment-ember-loose@1.5.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(@types/ember__array@4.0.10(@babel/core@7.26.0))(@types/ember__component@4.0.22(@babel/core@7.26.0))(@types/ember__controller@4.0.12(@babel/core@7.26.0))(@types/ember__object@4.0.12(@babel/core@7.26.0))(@types/ember__routing@4.0.22(@babel/core@7.26.0))(ember-cli-htmlbars@6.3.0)(ember-modifier@4.1.0(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5))))(@glint/template@1.5.0)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)) ember-modifier: 4.1.0(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)) ember-source: 5.12.0(@glimmer/component@1.1.2(@babel/core@7.26.0))(@glint/template@1.5.0)(rsvp@4.8.5)(webpack@5.96.1)