Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SmartQueryGasLimit #2001

Open
chipshort opened this issue Oct 3, 2024 · 0 comments
Open

Deprecate SmartQueryGasLimit #2001

chipshort opened this issue Oct 3, 2024 · 0 comments

Comments

@chipshort
Copy link
Collaborator

We should slowly phase it out because it makes the SmartContractState query non-deterministic.
However, RPC nodes currently rely on this to prevent people from querying contracts with infinite loops.
We should redirect them to the Cosmos SDK query gas limit instead.

To summarize:

  • Deprecate SmartQueryGasLimit
  • Log a warning when it is provided (either in CLI or in config)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chipshort