Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sv::features attribute to avoid breaking API #446

Open
Tracked by #418
jawoznia opened this issue Oct 15, 2024 · 0 comments · Fixed by #447
Open
Tracked by #418

Add sv::features attribute to avoid breaking API #446

jawoznia opened this issue Oct 15, 2024 · 0 comments · Fixed by #447

Comments

@jawoznia
Copy link
Collaborator

jawoznia commented Oct 15, 2024

To overwrite Sylvia behavior without breaking the API in minor releases we will introduce new attribute #[sv::features()].

User will be able to pass the currently supported feature to enable new behavior.

For the reply feature we will support the #[sv::features(replies)].

We will be potentially able to reuse this attribute in the future while implementing better support for migrate.

jawoznia added a commit that referenced this issue Oct 15, 2024
Remove `sv_replies` feature as it does not make the change non breaking.
@jawoznia jawoznia linked a pull request Oct 15, 2024 that will close this issue
jawoznia added a commit that referenced this issue Oct 15, 2024
Remove `sv_replies` feature as it does not make the change non breaking.
jawoznia added a commit that referenced this issue Oct 16, 2024
Remove `sv_replies` feature as it does not make the change non breaking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant