Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omission of declaration in Interface IStorageContext #20

Open
Elencon opened this issue Jun 29, 2022 · 1 comment
Open

Omission of declaration in Interface IStorageContext #20

Elencon opened this issue Jun 29, 2022 · 1 comment

Comments

@Elencon
Copy link

Elencon commented Jun 29, 2022

	Hello
	I started to use your sdk for my personal projects
	I have some questions.
    in class public class StorageContext	there are two pairs of methods
	
	public async Task InsertOrReplaceAsync<T>(IEnumerable<T> models) where T : new()
	public async Task InsertOrReplaceAsync<T>(T model) where T : new()

	public async Task MergeOrInsertAsync<T>(IEnumerable<T> models) where T : new()
	public async Task MergeOrInsertAsync<T>(T model) where T : new()
	
	In Interface IStorageContext
	You do not declare 
	public  Task InsertOrReplaceAsync<T>(IEnumerable<T> models) where T : new()

    Is this is intentional or simply omission?
@dei79
Copy link
Member

dei79 commented Jun 29, 2022

Hello @Elencon ,

the method for single item is just a helper operation. I guess we can add it to the interface for convenience reasons. Are you able to provider a pull request?

Regards
Dirk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants