Document optional artifacts #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macfarla
reviewed
Jul 6, 2022
macfarla
reviewed
Jul 12, 2022
|
|
||
| ##### Key Vaults | ||
|
|
||
| - [Azure](https://github.com/ConsenSys/tessera/tree/master/key-vault/azure-key-vault): Adds support for key pairs stored in Azure Key Vault. |
There was a problem hiding this comment.
These aren't links to artifacts. To get the artifacts you have to go to dockerhub eg https://hub.docker.com/r/quorumengineering/tessera/tags?page=1&name=aws
There was a problem hiding this comment.
I think we don't want to link to dockerhhub here. This page is for installing by binary distribution. The section just above this is how to add the artifacts from the .jar files. This was to list the artifacts (and their repo folders), matching the info on the Tessera readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Use the following template to make sure your PR fits the Tessera documentation standard.
Before creating the PR
Make sure that:
Describe the change
Documents the available optional artifacts.
Issue fixed
Fixes #160
Impacted parts
For content changes:
For tool changes:
After creating your PR and tests have finished
Make sure that:
and added a preview link.
Preview
https://pegasys-tessera--164.com.readthedocs.build/en/164/HowTo/Get-started/Install/Distribution/#available-optional-artifacts